Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

H2OAC #75

Open
wants to merge 26 commits into
base: main
Choose a base branch
from
Open

H2OAC #75

wants to merge 26 commits into from

Conversation

florianjoerg
Copy link
Member

@florianjoerg florianjoerg commented Mar 6, 2023

Description

Development branch for including the advanced protonation scheme with H2OAC

Changes

The dictionaries to supply the states information to ProtexTemplates have changed.
To allow for multiple atoms in one molecules an atoms list can now be specified. A new additional information is the mode parameter, which can either be donor or acceptor. I.e.:

OAC_HOAC_H2OAC = {
    "OAC": {"atoms": [{"name": "O2", "mode": "acceptor", "equivalent_atom": "O1"}]},
    "HOAC": {
        "atoms": [{"name": "H", "mode": "donor"}, {"name": "O1", "mode": "acceptor"}]
    },
    "H2OAC": {"atoms": [{"name": "HO1", "mode": "donor", "equivalent_atom:": "H"}]},
}

The NaiveMCUpdate can now be used with include_equivalent_atom=True and reorient=True.
The Residue and ProtexTemplates classes have new methods. See the API docs.

Status

  • Ready to go

@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2023

Codecov Report

Merging #75 (5bf4c0f) into main (205378c) will decrease coverage by 4.36%.
The diff coverage is 53.24%.

❗ Current head 5bf4c0f differs from pull request most recent head 63bbd3d. Consider uploading reports for the commit 63bbd3d to get more accurate results

Additional details and impacted files

@florianjoerg florianjoerg added the enhancement New feature or request label May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants